Merge pull request #229 from jason-fox/feature/node-10

Fully Remove Node 10
telefonicaid · Feb 24, 2021 · 793bcc3 · 793bcc3
2 parents eed1ad3 + 0f1613d
commit 793bcc3
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -62,6 +62,7 @@ jobs:
     strategy:
       matrix:
         node-version:
+          # FIXME: node v10 has been deprecated, but we are going to keep its regression for a while
           - 10.x
           - 12.x
           - 14.x

diff --git a/CHANGES_NEXT_RELEASE b/CHANGES_NEXT_RELEASE
@@ -1 +1,2 @@
-
+- Upgrade NodeJS version from 10 to 12 in Dockerfile due to Node 10 End-of-Life
+- Set Nodejs 12 as minimum version in packages.json (effectively removing Nodev10 from supported versions)
diff --git a/docker/Dockerfile b/docker/Dockerfile
@@ -19,7 +19,7 @@
 # For those usages not covered by the GNU Affero General Public License
 # please contact with: [sc_support at telefonica dot com]
 
-ARG NODE_VERSION=10
+ARG NODE_VERSION=12
 ARG GITHUB_ACCOUNT=telefonicaid
 ARG GITHUB_REPOSITORY=iotagent-manager
 ARG DOWNLOAD=latest

diff --git a/package.json b/package.json
@@ -16,7 +16,7 @@
   },
   "main": "lib/iotagent-manager",
   "engines": {
-    "node": ">=10"
+    "node": ">=12"
   },
   "scripts": {
     "clean": "rm -rf package-lock.json && rm -rf node_modules && rm -rf coverage",
-Original file line number
+Diff line change
@@ Expand Up / @@ -62,6 +62,7 @@ jobs: @@
         strategy:
           matrix:
             node-version:
+              # FIXME: node v10 has been deprecated, but we are going to keep its regression for a while
               - 10.x
               - 12.x
               - 14.x
@@ Expand Down @@
Original file line number	Diff line number	Diff line change
		@@ -1 +1,2 @@

		- Upgrade NodeJS version from 10 to 12 in Dockerfile due to Node 10 End-of-Life
		- Set Nodejs 12 as minimum version in packages.json (effectively removing Nodev10 from supported versions)