-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Add geofencing subscription example #4431
Conversation
Expand the examples set is always good :) However, instead of replacing the existing example with |
What do you mean by "extending the table field"? |
Adding something like: When using a geoquery as notification condition, you must include |
As alternative (probably clearer and simpler):
|
Co-authored-by: Fermín Galán Márquez <[email protected]>
doc/manuals/orion-api.md
Outdated
"expression": { | ||
"georel": "near;maxDistance:15000", | ||
"geometry": "point", | ||
"coords": "coords": "37.407804, -6.004552" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"coords": "coords": "37.407804, -6.004552" | |
"coords": "37.407804,-6.004552" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done at e56a7be
doc/manuals/orion-api.md
Outdated
"expires": "2025-04-05T14:00:00.00Z", | ||
"throttling": 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"expires": "2025-04-05T14:00:00.00Z", | |
"throttling": 5 | |
"expires": "2025-04-05T14:00:00.00Z" |
Remove also in L3891.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done at e56a7be
@@ -3892,6 +3892,38 @@ Example: | |||
} | |||
``` | |||
|
|||
Example using geoquery as condition: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L3865 should be changed to "Example using attribute filter".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done at e56a7be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fisuda this PR does some modifications to the documentation. It would be great if you could sync the Japanese translation, please. Thanks in advance! |
I sent the PR #4443. Thanks. |
(JP) [Doc] Add geofencing subscription example (#4431)
Orion documentation lacks a geofencing subscription example, and it is not pretty straightforward from documentation, since it is almost based on queries, not on subscriptions.
Maybe extending this table field here could help:
fiware-orion/doc/manuals/orion-api.md
Line 3654 in 442541c
@fgalan what do you think?