Fix partial success HTTP status codes

[chetan-NEC]

Fix #3054

• Change response code for partially successful updated entities

[fgalan]

Thanks you for your contribution!

Could you upgrade chetan-NEC:partial-success-http-status-codes branch which master branch, please? The CI docker image has been updated to use mongoc 1.23.1 and you need to bring to your PR the changes in CMakeList.txt and src/lib/rest/rest.cpp already in PR #4259 currently merged in master.

[chetan-NEC]

Hi @fgalan, the branch has been upgraded.

[chetan-NEC]

Gentle reminder!

[chetan-NEC]

Hi @fgalan, Gentle reminder!

[chetan-NEC]

Hi @fgalan, I have achieved the desired functionality, but NGSIv1-related test cases have failed. 
So, do you have any suggestions? 
Thank you in advance for your time and assistance. I look forward to reading your response.

[fgalan]

I had some time to have a look to the PR. First of all, thank for your willingness to contribute.

However, I'm still concerned about the backward compatibility issues that I commented in the past.

So maybe it's not a good idea to do the kind of changes this PR is proposing. Maybe it was a good idea when issue #3054 was created times ago, but NGSIv2 API usage has consolidated and I think there is little gain in implementing that issues (versus a high impact in backward compability).

Thus, I'd propose the following:

1. Close issue Partial success HTTP status codes #3054 explaining the above rationale
2. Closing PR Fix partial success HTTP status codes #4266 (along with previous PR Fix Partial success HTTP status codes #3054 #4003)

@chetan-NEC what do you think, please?

[chetan-NEC]

@fgalan, I spend lot of time to achieve the required functionality, but I really agree with your recommendation to close this PR.

[fgalan]

@fgalan, I spend lot of time to achieve the required functionality, but I really agree with your recommendation to close this PR.

Your time has not been wasted :) It has been very useful to reach the conclusion about what to do with the issue, which is also very important.

Note also that even in the case we want to change the behaviour, the work would not be finished. New tests (the ones described here) would need to be implemented, which would involve more effort (with uncertain result).

Having said that, if you have a proposal on how to fix the issue without involving backward compatibility problems, please go ahead with the suggestion. My proposal of closing the issue along with related PRs is due to I don't see any good solution... but if somebody does please tell me about :)

Otherwise, please @chetan-NEC close PR #4266 and I'll go ahead with the remaning closing actions.

Thanks for your feedback!

[chetan-NEC]

Thanks for your feedback!
I have closed the PR.