Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD test cases for attribute deletion for subscription triggering #4204

Merged
merged 4 commits into from
Aug 31, 2022

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Aug 30, 2022

This PR enhance the test suite with two new cases, covering attribute deletion for triggering subscription. In particular:

  • A test case to ensure that deleting an attribute in subject.condition triggers the notification
  • A test case to ensure that deleting an attribute not in subject.condition doesn't triggers the notification

CC: @Anjali-NEC maybe you want to have a look and provide feedback, as this PR is somehow related with your PR #4186.

Pending:

  • Doc modifications (to "Notification Triggering" subsection)

@fgalan fgalan changed the title [WIP] ADD test cases for attribute deletion for subscription triggering ADD test cases for attribute deletion for subscription triggering Aug 31, 2022
Copy link
Member

@mrutid mrutid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrutid mrutid merged commit 05e8a0c into master Aug 31, 2022
@mrutid mrutid deleted the hardening/sub_attrs_deletion_test_cases branch August 31, 2022 13:00
@fgalan
Copy link
Member Author

fgalan commented Aug 31, 2022

@fisuda this PR does slight modifications to orion-api.md document. It would be great if you could do a PR to sync the Japanese translation, please. Thanks!

@fisuda
Copy link
Contributor

fisuda commented Sep 1, 2022

I sent the PR #4208. Thanks.

fgalan added a commit that referenced this pull request Sep 1, 2022
(JP) ADD doc about attribute deletion for subscription triggering (#4204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants