Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.13.x] Migrate to GitHubAction for GolangCI Lint #921

Conversation

tekton-robot
Copy link

This is an automated cherry-pick of #915

/assign khrm

Your release note here

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 17, 2025
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 17, 2025
@khrm
Copy link
Contributor

khrm commented Jan 17, 2025

/approve

@tekton-robot
Copy link
Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@khrm
Copy link
Contributor

khrm commented Jan 17, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
@tekton-robot
Copy link
Author

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/log/s3.go 40.8% 37.7% -3.2

@khrm
Copy link
Contributor

khrm commented Jan 17, 2025

/test pull-tekton-results-unit-tests

1 similar comment
@khrm
Copy link
Contributor

khrm commented Jan 17, 2025

/test pull-tekton-results-unit-tests

@tekton-robot tekton-robot merged commit cd554b4 into tektoncd:release-v0.13.x Jan 17, 2025
7 checks passed
@khrm
Copy link
Contributor

khrm commented Jan 22, 2025

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants