Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define custom categories for the auto-generated release notes #3921

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

AlanGreene
Copy link
Member

Changes

Define custom categories matching the existing release note sections so that the auto-generated release notes more closely match the desired format.

Any items appearing in the 'Other changes to review' category should be reviewed to determine if they should be included, and if so should be manually moved to the appropriate category.

Unfortunately it's not possible to include custom header / footer content, e.g. our attestation or thanks sections, in the auto-generated release notes so we can't use this approach to produce the complete document. However, there is an API we can call to generate these release notes and use the returned content as part of another automation. This will be based on the release-draft Pipeline from the plumbing repo and delivered in a separate change.

In the meantime, this change still reduces the amount of manual effort required to create a new release.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jan 21, 2025
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 21, 2025
@AlanGreene AlanGreene requested review from LyndseyBu and removed request for skaegi January 21, 2025 21:12
@AlanGreene
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
Define custom categories matching the existing release note sections
so that the auto-generated release notes more closely match the
desired format.

Any items appearing in the 'Other changes to review' category should
be reviewed to determine if they should be included, and if so should
be manually moved to the appropriate category.

Unfortunately it's not possible to include custom header / footer content,
e.g. our attestation or thanks sections, in the auto-generated release
notes so we can't use this approach to produce the complete document.
However, there is an API we can call to generate these release
notes and use the returned content as part of another automation. This
will be based on the `release-draft` Pipeline from the plumbing repo
and delivered in a separate change.

In the meantime, this change still reduces the amount of manual effort
required to create a new release.
@AlanGreene AlanGreene force-pushed the release_autogen_categories branch from 09108e9 to 916805e Compare January 22, 2025 15:39
@AlanGreene
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2025
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@tekton-robot tekton-robot merged commit fb6a783 into tektoncd:main Jan 22, 2025
12 checks passed
@AlanGreene AlanGreene deleted the release_autogen_categories branch January 22, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants