-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #PS-0000 merge: Merge Release 1.1.0 into Release-1.2.0 #684
Conversation
Issue task PS-3887 : mark centre popup conditional rendering
…horizontal scroll on windows browsers
Issue task PS-3887 feat :- mark centre popup conditional rendering
Caution Review failedThe pull request is closed. WalkthroughThis update introduces changes across several components to enhance attendance management and UI responsiveness. New translations for attendance prompts are added to the locale file. Component modifications include adjustments to state handling and logging in lists, UI refinements in modals and drawers, and updated layout calculations for responsiveness. In the dashboard, a new state and handler manage remote cohort attendance with telemetry integration and conditional modal rendering. Utility functions for date formatting are now employed within the modal for clearer display. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Dashboard
participant Telemetry
participant Modal
User->>Dashboard: Click Attendance Button
Dashboard->>Dashboard: Execute handleRemoteSession()
alt Cohort is Remote
Dashboard->>Telemetry: Send telemetry event
Dashboard->>Dashboard: Set isRemoteCohort = true
Dashboard->>Modal: Render ModalComponent (attendance prompt)
else Non-Remote Cohort
Dashboard->>Dashboard: Execute handleModalToggle()
Dashboard->>Modal: Render ModalComponent
end
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (7)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
Summary by CodeRabbit
New Features
Style Improvements