Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

June15 pilot #236

Merged
merged 623 commits into from
Jul 4, 2024
Merged

June15 pilot #236

merged 623 commits into from
Jul 4, 2024

Conversation

vaivk369
Copy link
Collaborator

@vaivk369 vaivk369 commented Jul 4, 2024

Summary by CodeRabbit

  • New Features

    • Introduced multiple GitHub Actions workflows for various deployments and QA processes.
    • Added configurations for Kubernetes deployment.
  • Bug Fixes

    • Updated the Dockerfile to downgrade Node.js version for compatibility.
  • Improvements

    • Enhanced error handling and response formatting across several services.
    • Updated docker-compose.yml with renamed services and improved configurations.
    • Introduced several new methods in existing services for better functionality and error management.
  • Dependencies

    • Updated various dependencies in package.json for improved performance and security.

Dhanashree-Patil95 and others added 30 commits April 19, 2024 16:39
Fix[Fix Mark and update attendance API due to change in search API]
Fix[Seperate API for attendance Report and swagger changes ]
Cohort Member : cohort member CRUD APIs
AbhilashKD and others added 28 commits May 31, 2024 18:21
Update Profile: Store wrong data into database
Issue Fix PS-766: Added DTO validation in Update User API
Issue PS-766 fix: Added minor chaneg in update DTO.
User: Update user data field value
User Create: Email Field Optional for User Creation
Copy link

coderabbitai bot commented Jul 4, 2024

Warning

Review failed

The pull request is closed.

Walkthrough

The update introduces multiple actions and structural adjustments across various files. Key changes include new GitHub Actions workflows for deployment and CI/CD, updates to service locator interfaces and methods, dependency version adjustments in package.json, and Kubernetes deployment definitions. Notably, a new configuration file .coderabbit.yaml has been added, Docker configurations for Node.js have been updated, and Jenkinsfile now includes stages for a CI/CD pipeline.

Changes

File(s) Change Summary
.coderabbit.yaml Introduced configuration settings for code reviews following best JavaScript/TypeScript practices, auto-reviews, and auto-reply settings.
.github/workflows/docker-image.yml Modified CI workflow to trigger on pushes to the oblf-21stFeb branch.
.github/workflows/eks-pratham-deployment.yaml, .github/workflows/pratham-qa.yml, .github/workflows/prod-oblf.yml Added new workflow files for deployments to various environments (EKS-Pratham, QA, DEV).
Dockerfile Downgraded Node.js version from 21.1.0 to 20.
Jenkinsfile Introduced a CI/CD pipeline with stages for checkout, building, deploying using Docker, and notifications to Slack.
docker-compose.yml Renamed the main service to backend, modified image, container name, ports, and environment settings.
manifest/backend.yaml Added Kubernetes Deployment and Service configuration for backend application.
package.json Updated dependency versions and added new dependencies including @nestjs/passport, @nestjs/typeorm, date-fns, passport-jwt, typeorm, and more.
src/adapters/assignprivilegelocater.ts, src/adapters/assignroleservicelocater.ts, src/adapters/attendanceservicelocator.ts, src/adapters/cohortMembersservicelocator.ts, src/adapters/cohortservicelocator.ts, src/adapters/fieldsservicelocator.ts Introduced or modified service locator interfaces with methods for privilege roles, role assignments, attendance, cohort members, cohorts, and fields, featuring updates in method signatures and new methods.
src/adapters/hasura/attendance.adapter.ts, src/adapters/hasura/cohort.adapter.ts, src/adapters/hasura/cohortMembers.adapter.ts, src/adapters/hasura/fields.adapter.ts Updated class methods for better error handling, new methods added for cohort and attendance services, removed student DTO import, and included request parameters in methods.
src/adapters/hasura/hasura.module.ts Removed HasuraCommentService, HasuraGroupService, HasuraHolidayService, HasuraLikeService, and SchoolHasuraService. Added FieldsService.
src/adapters/hasura/rbac/assignrole.adapter.ts New file introducing HasuraAssignRoleService class with methods for role management.
src/adapters/hasura/rbac/privilege.adapter.ts Added HasuraPrivilegeService class with methods for privilege management.
src/adapters/hasura/services/fields.service.ts Refactored methods for FieldsService focusing on error handling and response generation.

Sequence Diagram(s)

sequenceDiagram
    actor Developer
    participant GitHub as GitHub Actions
    participant EKS as EKS Cluster
    participant Backend as Backend Service

    Developer->>GitHub: Push Code to repo (trigger specific branch)
    GitHub-->>GitHub: Run EKS Deployment Workflow
    GitHub-->>EKS: Build & Push Docker Image to ECR
    GitHub-->>EKS: Update Kube Config
    GitHub-->>EKS: Deploy to EKS Cluster
    EKS-->>Backend: Deploy Backend Service
    Backend-->>EKS: Service Running
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vaivk369 vaivk369 merged commit d705dbf into main Jul 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants