feat: TitleCase enhancement #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am commenting on this to give it more visibility. It would be nice if this PR could be merged and this shortcoming could be fixed. Articles and prepositions should not be capitalized in titles according to the APA guidelines. Thanks! |
Kirpal
reviewed
Dec 20, 2023
lib/recase.dart
Outdated
Comment on lines
151
to
152
| !isFirstWord && punctuationList.indexOf(words[word.key - 1]) > 0; | ||
| var isExcluded = exclusionListEng.indexOf(word.value) > 0; |
There was a problem hiding this comment.
Suggested change
| !isFirstWord && punctuationList.indexOf(words[word.key - 1]) > 0; | |
| var isExcluded = exclusionListEng.indexOf(word.value) > 0; | |
| !isFirstWord && punctuationList.contains(words[word.key - 1]); | |
| var isExcluded = exclusionListEng.contains(word.value); |
I think you should use contains, because indexOf(...) > 0 will return false if the value is the first element in the list, but it should be true for that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
DONE
Description
enhancement changes requested in issue #27 for TitleCase
Type of Change
✨ New feature (non-breaking change which adds functionality)