feat(chat): 채팅 직접 보낼 수 있도록 Handler 등록 및 scroll 구현 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seungholee-dev
force-pushed
the
feat/chat-display-name
branch
from
304db67 to
8d59047
Compare
seungholee-dev
force-pushed
the
feat/send-chat
branch
from
cc6293e to
09ddb89
Compare
|
임시 PR 입니다 :) 작성 완료 후 Review Request 할게요! |
seungholee-dev
force-pushed
the
feat/chat-display-name
branch
2 times, most recently
from
c30e8ff to
5b85ca7
Compare
seungholee-dev
force-pushed
the
feat/send-chat
branch
2 times, most recently
from
a44f02b to
c82e409
Compare
테스트 방법
|
seungholee-dev
force-pushed
the
feat/send-chat
branch
from
c82e409 to
d8175cf
Compare
|
Rebase 완료하여 코드 확인부탁드려요! |
seungholee-dev
force-pushed
the
feat/send-chat
branch
2 times, most recently
from
731f3f7 to
8f1da52
Compare
|
뒤에 연이은 PR이 많아서, 이 PR의 리뷰는 잠시 스킵해주시고 이후 PR들을 먼저 리뷰 해주시면 |
seungholee-dev
force-pushed
the
feat/send-chat
branch
5 times, most recently
from
ae6ec92 to
18d7a51
Compare
nnyouung
approved these changes
Jul 21, 2024
개요 - 어플 내부에서 채팅을 직접 보낼 수 있도록 Handler를 등록한다. 수정 사항 - handleSend 핸들러 함수를 onPress에 채팅을 보냄 - useRef를 사용해서 현재 최신 채팅을 기준으로 스크롤될 수 있도록 구성 (FlatList의 최신으로 갈 수 있게끔)
개요 - iOS에서 웹소켓 사용 시 필요로 하는 모듈인 text-encoding이 누락되어 이를 추가하여 고친다. (이 부분을 제외하면 iOS에서 stompjs 사용 불가) - React Native 프로젝트에서는 아래 링크에서 말하는대로 이 부분이 필수적으로 필요함 - 추가로, 이전 병합 과정에서 빠진 stompjs와 expo secure storage npm package를 재추가한다 아래 링크 참고: https://stomp-js.github.io/workaround/stompjs/rx-stomp/react-native-additional-notes.html
seungholee-dev
force-pushed
the
feat/send-chat
branch
from
18d7a51 to
3216f27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
수정 사항
(FlatList의 최신으로 갈 수 있게끔)