Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppression des assets autres que FR ou EN #906

Closed
wants to merge 2 commits into from
Closed

Suppression des assets autres que FR ou EN #906

wants to merge 2 commits into from

Conversation

NicolasBuquet
Copy link
Contributor

Fix #905

@NicolasBuquet NicolasBuquet requested a review from yostyle October 30, 2023 09:54
@NicolasBuquet NicolasBuquet linked an issue Oct 30, 2023 that may be closed by this pull request
Suppression des assets autres que FR ou EN #905
Closed
yostyle
yostyle reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est ce qu'il est possible d'exclure ces fichiers du projets au lieu de les supprimer ? sinon, il y'aura des conflits a chaque mise à jour d'un de ces fichiers lors des rebases.

@NicolasBuquet
Copy link
Contributor Author

Si on supprime le fichier de notre côté, il ne devrait pas être rajouté lors de rebase, non ?

On en discute.

@NicolasBuquet NicolasBuquet requested a review from yostyle October 31, 2023 11:18
@NicolasBuquet
Copy link
Contributor Author

Ces fichiers sont déjà exclus du projet Xcode.

Les supprimer du repository Git expose à des soucis de conflit lors des prochains rebase.

Commit reverted.

@NicolasBuquet NicolasBuquet deleted the 905-suppression-des-assets-autres-que-fr-ou-en branch October 31, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yostyle yostyle Awaiting requested review from yostyle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suppression des assets autres que FR ou EN
2 participants
@NicolasBuquet @yostyle