DurationFormat: Add tests for durations with style: "digital", hoursDisplay: "auto" and zero hours
#4367
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,36 @@ | ||||||
| // Copyright (C) 2024 Sosuke Suzuki. All rights reserved. | ||||||
| // This code is governed by the BSD license found in the LICENSE file. | ||||||
|
|
||||||
| /*--- | ||||||
| esid: sec-Intl.DurationFormat.prototype.format | ||||||
| description: > | ||||||
| The separator isn't printed when style is digital, hoursDisplay is auto and hours value is zero | ||||||
| locale: [en-US] | ||||||
| features: [Intl.DurationFormat] | ||||||
| ---*/ | ||||||
|
|
||||||
| const df = new Intl.DurationFormat("en", { | ||||||
| style: "digital", | ||||||
| hoursDisplay: "auto", | ||||||
| }); | ||||||
|
|
||||||
| const durations = [ | ||||||
| // basic zero hours | ||||||
| [{ hours: 0, minutes: 0, seconds: 2 }, "00:02"], | ||||||
| [{ hours: 0, minutes: 1, seconds: 2 }, "01:02"], | ||||||
| [{ days: 1, hours: 0, minutes: 1, seconds: 2 }, "1 day, 01:02"], | ||||||
|
|
||||||
| // without hours | ||||||
| [{ minutes: 0, seconds: 2 }, "00:02"], | ||||||
| [{ minutes: 1, seconds: 2 }, "01:02"], | ||||||
| [{ days: 1, minutes: 1, seconds: 2 }, "1 day, 01:02"], | ||||||
|
|
||||||
| // negative sign | ||||||
| [{ hours: 0, minutes: -1, seconds: -2 }, "-01:02"], | ||||||
| [{ hours: 0, minutes: -1, seconds: -2 }, "-01:02"], | ||||||
| [{ days: -1, hours: 0, minutes: -1, seconds: -2 }, "-1 day, 01:02"], | ||||||
| ]; | ||||||
|
|
||||||
| for (const [duration, expected] of durations) { | ||||||
| assert.sameValue(df.format(duration), expected, `Duration is ${duration}`); | ||||||
|
There was a problem hiding this comment.
Suggested change
Otherwise |
||||||
| } | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chrome prints
"1 day:01:02"for this, which is correct?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like a V8 bug.
In FormatNumericUnits, steps 10-11 will set
hoursFormattedtofalse, because the hour value is zero and the hours display is not"always". Step 17 passeshoursFormattedto FormatNumericMinutes. FormatNumericMinutes, step 2 only appends the separator ifhoursDisplayedisfalse. And the value ofhoursDisplayedishoursFormattedfrom FormatNumericUnits. That means no separator should be appended for this case.