Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call assert.deepEqual.format when the assertion will succeed #4358

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Don't call assert.deepEqual.format when the assertion will succeed #4358

merged 1 commit into from
Dec 18, 2024

Conversation

anba
Copy link
Contributor

@anba anba commented Dec 18, 2024

No description provided.

@anba anba requested a review from a team as a code owner December 18, 2024 10:06
@anba
Copy link
Contributor Author

anba commented Dec 18, 2024

"staging/sm/TypedArray/forEach" needs multiple seconds without this change. With this change applied, it completes in under a second.

Ms2ger
Ms2ger approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@Ms2ger Ms2ger enabled auto-merge (rebase) December 18, 2024 15:15
@Ms2ger Ms2ger merged commit 900c802 into tc39:main Dec 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anba @Ms2ger