Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Simplify ParseTemporalCalendarString #3077

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Editorial: Simplify ParseTemporalCalendarString #3077

merged 1 commit into from
Jan 25, 2025
+4 −5

Conversation

gibson042
Copy link
Collaborator

Ref #3076

@gibson042 gibson042 requested a review from ptomato January 23, 2025 16:46
@gibson042 gibson042 mentioned this pull request Jan 23, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (2681429) to head (a9c50bf).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3077   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files          21       21           
  Lines        9872     9872           
  Branches     1800     1800           
=======================================
  Hits         9514     9514           
  Misses        311      311           
  Partials       47       47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

justingrant
justingrant approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@justingrant justingrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ptomato
ptomato approved these changes Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ptomato ptomato merged commit 1b1fd9f into tc39:main Jan 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato approved these changes

@justingrant justingrant justingrant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gibson042 @justingrant @ptomato