fix(macOS): race conditions around WKURLSchemeTask #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmoon
force-pushed
the
wkurlschemetask-crash
branch
2 times, most recently
from
8f7644e to
2139170
Compare
Package Changes Through 210a651There are 1 changes which include wry with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
alexmoon
force-pushed
the
wkurlschemetask-crash
branch
from
2139170 to
89b2b5c
Compare
Fixes two issues which could cause race conditions when navigating between pages while custom protocol requests are in progress on macOS and iOS: - The `obc2/catch-all` feature turns all Objective-C exceptions into panics, preventing `obc2::exception::catch(...)` from working. - The `webview` and `task` objects passed to `start_task` were not retained, leading to use-after-free issues in the `responder`. - `WryWebView::remove_custom_task_key` is called from both `stop_task` and `response` which may be in different threads, so `custom_protocol_task_ids` needs to be protected by a `Mutex`. Closes tauri-apps#1189
alexmoon
force-pushed
the
wkurlschemetask-crash
branch
from
89b2b5c to
210a651
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues which could cause race conditions when navigating between pages while custom protocol requests are in progress on macOS and iOS:
obc2/catch-allfeature turns all Objective-C exceptions into panics, preventingobc2::exception::catch(...)from working.webviewandtaskobjects passed tostart_taskwere not retained, leading to use-after-free issues in theresponder.WryWebView::remove_custom_task_keyis called from bothstop_taskandresponsewhich may be in different threads, socustom_protocol_task_idsneeds to be protected by aMutex.Closes #1189