Remove pos length check in test_long
#444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some pages use the template `zh-see` to redirect simplified Chinese characters don't have POS title. Not sure why the pr 174 of wikitextprocessor affects this test. Another change is adding the redirect data to `pos_data` if it's not empty.
|
I also see some "can't find template" errors in page https://en.wiktionary.org/wiki/数, this was ignored before tatuylonen/wikitextprocessor#174, maybe the error should be removed? |
|
Let's merge this if it fixes the issue with the test first, then wonder about errors later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some pages use the template
zh-seeto redirect simplified Chinese characters don't have POS title. Not sure why the pr 174 of wikitextprocessor affects this test.Another change is adding the redirect data to
pos_dataif it's not empty.