Improving the German, Spanish and Russian extractors #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found for example in: https://de.wiktionary.org/wiki/insula
It seems safe to treat sections with titles: === Forma verbal === === Forma sustantiva (?) === === Forma adjetiva === === Forma pronominal === === Forma de participio === as introducing POS sections. This does not yet deal with headings such as: === Forma adjetiva y de participio === introducing two POS at the same time.
|
I was coincidentially wondering how should I approach extracting Spanish "forma verbal" sections since I see a lot of words reporting "Unprocessed section: forma verbal" |
|
Thanks for your contribution! |
|
Thanks for the review and quick acceptance of my PR! As mentioned, I achieved what I set out to do and will be a less active contributor from here on out. I will keep an eye on the developments and see if any problem with my code occur. Please feel free to tag me whenever. Finally, I want to say that it was a pleasure contributing and collaborating. Thanks for all the help and encouragement along the way! |
|
Thank you for your contributions! It was great to have you working with us, good luck with future projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
This will probably be my last bigger PR in a while.
The last item on my list was to check how well the new extractors perform when extracting Latin and Ancient Greek data. This PR addresses a bunch of issues/improvements I noted in the process.
Let me know if you prefer that I rather add these in separate PRs.