Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalise mode's display name #26

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Capitalise mode's display name #26

merged 1 commit into from
Jan 21, 2025

Conversation

frou
Copy link
Contributor

@frou frou commented Jan 21, 2025

It's conventional for a mode's display name to be capitalised. At the moment, it looks weird to have a component of the mode-line be all-lowercase 😅

@xvw
Copy link
Member

xvw commented Jan 21, 2025

Thanks a lot!
Can you maybe a change entry (in CHANGES.md)?

ocaml-eglot unreleased
======================

- Fix lighter case ([#26](https://github.com/tarides/ocaml-eglot/pull/26))

<Rest of the document>

Thanks in advance!

@frou
Copy link
Contributor Author

frou commented Jan 21, 2025

Done. I now noticed you don't capitalise the 'E' elsewhere so rolled that part back.

@xvw xvw merged commit 0ddd389 into tarides:main Jan 21, 2025
4 checks passed
@xvw
Copy link
Member

xvw commented Jan 21, 2025

Thanks!

@frou
Copy link
Contributor Author

frou commented Jan 21, 2025

Thank you for the fantastic project. It's a really great initiative so that Emacs doesn't get left behind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants