-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): block win sound #372
Conversation
Marking as controversial because of the permissions change |
I want a block win sound. What exactly is the problem with permissions? |
We need permissions for reading buffered file but I had problem with assign correct scope for just a single file that we needed and I ended up with I tried using something like |
Managed to reduce the read access to just the audio file so now it's much less controversial. |
Tested on Ubuntu | MacOS | Windows 11 and works on each one |
I can't currently test this because every time I win I get lose animations. Once we fix the animation timing, I'll come back to this. |
We need the block win sound to also play on the block win replay. |
Can you also add an event item that tracks when the sound is toggled? |
Added boolean in the {
"app_id": "hJr@t#FsvG30Mn2QLAS$",
"cpu_name": "11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz",
"created_at": {
"nanos_since_epoch": 597927466,
"secs_since_epoch": 1738765756
},
"event_name": "audio-enabled",
"event_value": false,
"gpu_name": "Intel(R) Iris(R) Xe Graphics [0x9a49]",
"os": "Linux",
"user_id": "v3,TFKEtEunDgrKrSkVYG54zU6x4tuJ,0.9.2,47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU",
"version": "0.9.2"
} |
Description
Add sound effect when block is mined.
Motivation and Context
More feedback to the user.
How Has This Been Tested?
Replaced condition to run audio and tested manually.
What process can a PR reviewer use to test or verify this change?
Same as above.
Breaking Changes