fix: app stuck on shutting down #1465
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1297
Sometimes app is stuck on shutting down screen. This is caused by deadlock between handling same event on the frontend and backend.
Motivation and Context
Fix breaking bug.
How Has This Been Tested?
I couldn't recreate this bug - tried reset setting before closing but it's still exit without hanging up.
This implementation didn't caused any issue but it's required to test this PR by someone who can recreate this.
What process can a PR reviewer use to test or verify this change?
Close app in various stages and check if anything strange happens.
Breaking Changes