feat: batch verification #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
batching
branch
from
57cf780 to
56267ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds batch verification functionality, where multiple proofs sharing a common input set can be efficiently verified together. This is done internally by adding a new
Proof::verify_batchthat accepts statement and proof slices, checks their consistency, and then goes to work. To keep the API cleaner, the existingverifyfunctionality becomes a trivial wrapper. This doesn't result in any efficiency hit for the single-proof case, but provides significant benefits for nontrivial batching.It also adds a simple test and benchmarks.
Closes #21.