Add commutative multiplication on primitive scalar types for Vectors #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunsided
changed the title
|
I did not add scalar |
tarcieri
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one partially addresses #105 and the implementation is somewhat debatable. In general, commutative operations (e.g.
Mul<C> for Vector3d<C>andMul<Vector3d<C>> for C) cannot be implemented due to trait implementation coherence rules.Given that the crate exports some standard types such as
F32x2,I16x3etc. it is at least possible to define commutative math for these specific implementations, and this is what this PR does.