-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate cluster module and adapt it #406
Conversation
5ee650d
to
5431a1c
Compare
The changes I've made to the original helper:
local t = require('luatest')
-- If the created cluster is saved in g.cluster the clash occurs
local cluster = t.cluster.new(...)
- server:exec(function()
- t.helpers.retrying({timeout = 60}, function()
- t.assert_equals(box.info.status, 'running')
- end)
+ helpers.retrying({timeout = 60}, function()
+ assertions.assert_equals(server:eval('return box.info.status'),
+ 'running')
|
8dfbae0
to
902f6db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've no objections. Thanks for working on it!
Left a few remarks about consistency with other luatest APIs.
902f6db
to
87bdbc0
Compare
87bdbc0
to
9065a1d
Compare
The original `cluster` module (tarantool/test/config-luatest/cluster.lua) has been moved to the current project and will be available as follows: ```lua local t = require('luatest') local cluster = t.cluster:new(...) cluster:start() ``` It is used to simplify managing Tarantool clusters based on the provided configuration. The helper requires Tarantool 3.0.0 or newer. Otherwise cluster methods cause an error. Original helper created by: [email protected] Test author: [email protected] Closes tarantool#368
9065a1d
to
4329a6d
Compare
@georgiy-belyanin Thanks for the updates! I'm ready to merge it. @locker Do you have any objections regarding luatest-consistent API? Personally, I don't like all this quazi-oop, but it seems like this is the luatest way. |
No. |
The original
cluster
module (tarantool/test/config-luatest/cluster.lua) has been moved to the current project and will be available as follows:It is used to simplify managing Tarantool clusters based on the provided configuration. The helper requires Tarantool 3.0.0 or newer. Otherwise cluster methods cause an error.
Original helper created by: [email protected]
Test author: [email protected]
Closes #368