New Feature : Star Icon get filled when note is favorite ⭐️ #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now, when we click on the Star icon to add a note to our favorites the star stay the same colour. Which is confusing because it doesn't show us that the note has been added to our favorites.
To solve this UX issue we just need to fill the star icon with an orange colour to tell the user that this note is one of our favorites.
I've also add this behaviour to the contextual menu.
Closes issue #511.
Browser checklist
This PR has been tested in the following browsers:
Testing checklist