Merge branch 'develop' into elizabeth/update-python-and-dependencies

sleap/gui/app.py

@@ -377,7 +377,9 @@ def add_menu_item(menu, key: str, name: str, action: Callable):
         def connect_check(key):
             self._menu_actions[key].setCheckable(True)
             self._menu_actions[key].setChecked(self.state[key])
-            self.state.connect(key, self._menu_actions[key].setChecked)
+            self.state.connect(
+                key, lambda checked: self._menu_actions[key].setChecked(checked)
+            )
 
         # add checkable menu item connected to state variable
         def add_menu_check_item(menu, key: str, name: str):

sleap/gui/dataviews.py

@@ -413,13 +413,6 @@ def set_item(self, item, key, value):
         elif key == "symmetry":
             self.context.setNodeSymmetry(skeleton=self.obj, node=item, symmetry=value)
 
-    def get_item_color(self, item: Any, key: str):
-        if self.skeleton:
-            color = self.context.app.color_manager.get_item_color(
-                item, parent_skeleton=self.skeleton
-            )
-            return QtGui.QColor(*color)
-
 
 class SkeletonEdgesTableModel(GenericTableModel):
     """Table model for skeleton edges."""
@@ -436,14 +429,6 @@ def object_to_items(self, skeleton: Skeleton):
             ]
         return items
 
-    def get_item_color(self, item: Any, key: str):
-        if self.skeleton:
-            edge_pair = (item["source"], item["destination"])
-            color = self.context.app.color_manager.get_item_color(
-                edge_pair, parent_skeleton=self.skeleton
-            )
-            return QtGui.QColor(*color)
-
 
 class LabeledFrameTableModel(GenericTableModel):
     """Table model for listing instances in labeled frame.

tests/gui/test_app.py

@@ -414,6 +414,12 @@ def toggle_and_verify_visibility(expected_visibility: bool = True):
         window.showNormal()
     vp = window.player
 
+    # Change state and ensure menu-item check updates
+    color_predicted = window.state["color predicted"]
+    assert window._menu_actions["color predicted"].isChecked() == color_predicted
+    window.state["color predicted"] = not color_predicted
+    assert window._menu_actions["color predicted"].isChecked() == (not color_predicted)
+
     # Enable distinct colors
     window.state["color predicted"] = True