-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tips and add jupyter lab to the environment #75
Fix tips and add jupyter lab to the environment #75
Conversation
WalkthroughThe changes in this update encompass enhancing testing clarity, updating package versions, and improving workflow configurations. From detailed testing improvements to version updates, these modifications aim to refine processes and maintain consistency. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Jupyter notebooks are located in this repo at `sleap-roots/notebooks`. | ||
|
||
To use them, activate your conda environment which includes JupyterLab (recommended): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instructions for using Jupyter notebooks have been removed. This could potentially confuse new users who might still need these instructions to understand how to use the notebooks provided in the repository.
+ To use the Jupyter notebooks, activate your conda environment which includes JupyterLab (recommended):
+ ```
+ conda activate sleap-roots
+ ```
+ Clone this repository if you haven't already:
+ ```
+ git clone https://github.com/talmolab/sleap-roots.git && cd sleap-roots
+ ```
+ Then you can change directories to the location of the notebooks, and open Jupyter Lab:
+ ```
+ cd notebooks
+ jupyter lab
+ ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Actionable comments outside the diff hunks (1)
sleap_roots/__init__.py (1)
Line range hint
14-22
: Several imports are flagged as unused. Consider removing them or adding them to__all__
if they are intended for public API use.- import sleap_roots.trait_pipelines - from sleap_roots.trait_pipelines import ( - DicotPipeline, - TraitDef, - YoungerMonocotPipeline, - OlderMonocotPipeline, - MultipleDicotPipeline, - ) - from sleap_roots.series import Series, find_all_series
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 74.90% 74.92% +0.01%
==========================================
Files 13 13
Lines 1307 1312 +5
==========================================
+ Hits 979 983 +4
- Misses 328 329 +1 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
tips
, verified the y-coordinates of the tips, and updated the test case to reflect changes in tip calculation logic in thetest_get_tip_ys_no_tip
function.codecov/codecov-action
fromv3
tov4
in the CI workflow for uploading coverage reports.sleap_roots/__init__.py
file.