Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding FPS metadata to
Video
formats #105Adding FPS metadata to
Video
formats #105Changes from all commits
70a34ed
06cc444
e97ecc7
4de9012
1aa64f8
9063bc3
6a7861d
5620a2b
c40c814
c1c925c
c8e8ab0
8a1ef98
6d4031a
47fb60e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update type hint for
_frame_rate
parameter infrom_filename
method.The type hint for
_frame_rate
should beOptional[float]
instead ofOptional[bool]
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This conditional is necessary because
ImageVideo
inherits fromVideoBackend
. If we try to check the frame rate ofImageVideo
objects, which are stored as image files, we will get an error.