Add countermeasure to avoid crash in cxx_destruct during deallocati…

…on of mapping result
tabeso · Feb 25, 2013 · 490b233 · 490b233
1 parent f36dcde
commit 490b233
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/Code/Network/RKManagedObjectRequestOperation.m b/Code/Network/RKManagedObjectRequestOperation.m
@@ -315,6 +315,17 @@ - (id)initWithHTTPRequestOperation:(RKHTTPRequestOperation *)requestOperation re
     return self;
 }
 
+/**
+ NOTE: This dealloc implementation attempts to avoid crashes coming from Core Data due to the ordering of deallocations under ARC. If the MOC is deallocated before its managed objects, it can trigger a crash. We dispose of the mapping result and reset the private context to avoid this situation. The crash manifests itself in `cxx_destruct`
+ [sbw - 2/25/2013]
+ */
+- (void)dealloc
+{
+    _mappingResult = nil;
+    _responseMapperOperation = nil;
+    _privateContext = nil;
+}
+
 - (void)setTargetObject:(id)targetObject
 {
     [super setTargetObject:targetObject];

diff --git a/Code/Network/RKObjectRequestOperation.h b/Code/Network/RKObjectRequestOperation.h
@@ -62,7 +62,10 @@
  @see `RKMIMETypeSerialization`
  @see `RKManagedObjectRequestOperation`
  */
-@interface RKObjectRequestOperation : NSOperation <RKMapperOperationDelegate>
+@interface RKObjectRequestOperation : NSOperation <RKMapperOperationDelegate> {
+  @protected
+    RKMappingResult *_mappingResult;
+}
 
 ///-----------------------------------------------
 /// @name Initializing an Object Request Operation