Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed import assert to with #28

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

matdru
Copy link
Contributor

@matdru matdru commented Jan 8, 2025

User description

Changes

  • changed import assert syntax to with which fixes compatibility with Node 22

Why

CLI wouldn't run on node 22, more details here: #27


PR Type

Bug fix


Description

  • Updated import syntax from assert to with for compatibility.

  • Fixed CLI compatibility issues with Node.js 22.

  • Adjusted imports in src/cli.tsx and src/components/Branding.tsx.


Changes walkthrough 📝

Relevant files
Bug fix
cli.tsx
Update `import` syntax in CLI entry file                                 

src/cli.tsx

  • Changed import syntax for packageJson from assert to with.
  • Ensures compatibility with Node.js 22.
  • +1/-1     
    Branding.tsx
    Update `import` syntax in Branding component                         

    src/components/Branding.tsx

  • Changed import syntax for packageJson from assert to with.
  • Ensures compatibility with Node.js 22.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    changeset-bot bot commented Jan 8, 2025

    🦋 Changeset detected

    Latest commit: 826251a

    The changes in this PR will be included in the next version bump.

    This PR includes changesets to release 1 package
    Name Type
    @t1mmen/srtd Patch

    Not sure what this means? Click here to learn what changesets are.

    Click here if you're a maintainer who wants to add another changeset to this PR

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ✅

    27 - PR Code Verified

    Compliant requirements:

    • Fix CLI compatibility with Node.js 22
    • Fix error when running CLI on Node.js 22

    Requires further human verification:

    • Verify that CLI runs successfully on Node.js 22 after changes
    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @wojteg1337
    Copy link

    Well done

    @t1mmen
    Copy link
    Owner

    t1mmen commented Jan 9, 2025

    Thank you, @matru! 🙏

    @t1mmen t1mmen merged commit b9890b0 into t1mmen:main Jan 9, 2025
    2 of 3 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants