Use assertions in code #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several methods that convert a collection to a set. In somerrr There are a number of assumptions made in the code about the program's flow of control and input of certain non-public methods. These assumptions are not checked and could potentially lead to bugs that are hidden in the program. Let's use assertions to document these important assumptions that should hold true during execution of the code. Assertions do not have a heavy impact on performance and allows quick detection of bugs arising from the assumptions made in the code. They also help to document some of the logic in the code and improves maintainability of the program.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of assumptions made in the code about the
program's flow of control and input of certain non-public methods.
These assumptions are not checked and could potentially lead to bugs
that are hidden in the program.
Let's use assertions to document these important assumptions that
should hold true during execution of the code.
Assertions do not have a heavy impact on performance and allows
quick detection of bugs arising from the assumptions made in the code.
They also help to document some of the logic in the code and improves
maintainability of the program.