Rectify length of Virtio descriptor address #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengwen-tw
suggested changes
Feb 1, 2025
virtio-blk.c
Outdated
| vq_desc[i].addr = desc->addr; | ||
| vq_desc[i].len = desc->len; | ||
| vq_desc[i].flags = desc->flags; | ||
| desc_idx = desc->next; /* vq_desc[desc_cnt].next */ |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
virtio-rng.c
Outdated
| .flags = desc[3], | ||
| }; | ||
| struct virtq_desc vq_desc = | ||
| *(struct virtq_desc *) &vrng->ram[queue->QueueDesc + buffer_idx * 4]; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
virtio-rng.c
Outdated
|
|
||
| /* Write entropy buffer */ | ||
| void *entropy_buf = | ||
| (void *) ((uintptr_t) vrng->ram + (uintptr_t) vq_desc.addr); | ||
| ssize_t total = read(rng_fd, entropy_buf, vq_desc.len); | ||
|
|
||
| /* Clear write flag */ | ||
| desc[3] = 0; | ||
| vq_desc.flags = 0; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
virtio.h
Outdated
| @@ -58,7 +58,7 @@ enum { | |||
| }; | |||
|
|
|||
| struct virtq_desc { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jserv
requested changes
Feb 2, 2025
otteryc
changed the title
According to Virtio Specification Version 1.3, Section 2.7.5 *The Virtqueue Descriptor Table*, the type of 'addr' should be 'uint64_t' instead of 'uint32_t'. This commit addresses the error in the previous implementation. Co-authored-by: Shengwen Cheng <[email protected]>
|
Thank @otteryc for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Virtio Specification Version 1.3, Section 2.7.5 The Virtqueue Descriptor Table, the type of
addrshould beuint64_tinstead ofuint32_t.This commit addresses the error in the previous implementation.