Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use importlib (Python 3.12 compatible) #173

Closed
wants to merge 1 commit into from

Conversation

Kilo59
Copy link

@Kilo59 Kilo59 commented Apr 11, 2024

Replace imp usage with importlib
imp has been removed in Python 3.12 so this should make this package compatible.

Tests all pass locally on Python 3.12.

@Kilo59 Kilo59 changed the title Use importlib (Python 3.12 comptabile) Use importlib (Python 3.12 compatible) Apr 11, 2024
@Kilo59 Kilo59 marked this pull request as ready for review April 11, 2024 16:16
@RobinTail
Copy link

Fixes #166

@jeremyk
Copy link

jeremyk commented Jul 24, 2024

Any update on this? Would be really nice to get it merged.

@ayys
Copy link
Collaborator

ayys commented Aug 1, 2024

@Kilo59 I am closing this as duplicate of #168, since the other PR is now merged.

@ayys ayys closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants