-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Physiology Models (Borked) #1254
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1254 +/- ##
==========================================
Coverage 78% 79%
- Complexity 3635 3874 +239
==========================================
Files 167 167
Lines 23659 24941 +1282
Branches 3220 3566 +346
==========================================
+ Hits 18643 19756 +1113
- Misses 3996 4160 +164
- Partials 1020 1025 +5 see 27 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…rved data, add support for benes that decline part B coverage.
…tof date. Exclude child beneficiaries.
…ommand line. Some additional refactoring to ensure claims are only emitted for years when the beneficiary file contains entries.
…into entitlement_codes
…h/synthea into entitlement_codes
Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
…h/synthea into entitlement_codes
Fix SDOH address category.
Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
Update BFD HHA Exporter
After a quick glance, here are a few quick thoughts:
|
Many of the wearable submodule files start with |
BigDecimal income = BigDecimal.valueOf((Integer) this.attributes.get(Person.INCOME)); | ||
BigDecimal yearlyCost = plan.getYearlyCost(); | ||
return income.multiply(BigDecimal.valueOf(incomePercentage)).compareTo(yearlyCost) == 1; | ||
int income = (int) this.attributes.get(Person.INCOME); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NULLPTR_DEREFERENCE: null (last assigned on line 776) is dereferenced.
❗❗ 2 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
File Path | Line Number |
---|---|
src/main/java/org/mitre/synthea/export/rif/CarrierExporter.java | 69 |
src/main/java/org/mitre/synthea/export/rif/BeneficiaryExporter.java | 487 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
|
||
double incomePercentage = Config.getAsDouble("generate.payers.insurance_plans.income_premium_ratio"); | ||
int income = 0; | ||
income = (int) this.attributes.get(Person.INCOME); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NULLPTR_DEREFERENCE: null (last assigned on line 777) is dereferenced.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/synthetichealth/synthea/1254.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diff Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/synthetichealth/synthea/1254.diff | git apply Once you're satisfied, commit and push your changes in your project. Footnotes |
Replaced by #1347 |
Synthea Physiology Simulations
The simulation configuration files in this directory can be used to execute a single run of a Synthea physiology model via the gradle command line interface. The configuration allows manipulation of the differential equation solver, step size, sim duration, and configuration for output charts if desired. Output files will be in the
output/physiology
directory.Note that these are only utilized for the physiology gradle command and are not part of the normal Synthea execution procedure.
Configuration
You will need to set the following two fields to
true
in thesrc/main/resources/synthea.properties
file.Usage
./gradlew physiology --args="config/simulations/[config name].yml"
Examples
Output
Graphs and raw data in CVS files will be found in
output/physiology
folder.You may also wish to create a large population of 10,000 or more individuals, and search for gallblader patients (which are currently the only patients that have ECG physiology data attached to them.)
References