Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added OLA management #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added OLA management #107

wants to merge 1 commit into from

Conversation

Fry-4TF1V
Copy link

Added support for OLA. Possible to aggregate/deaggregate all interfaces at once.

tortuegenialez
tortuegenialez requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@tortuegenialez tortuegenialez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.
We made some changes since your previous PR:

  • The OVH class is handling calls and errors
  • We try to normalise f-string usage

plugins/modules/dedicated_server_networkinterfacecontroller.py Outdated Show resolved Hide resolved
plugins/modules/dedicated_server_networkinterfacecontroller.py Outdated Show resolved Hide resolved
plugins/modules/dedicated_server_ola_configure.py Outdated Show resolved Hide resolved
plugins/modules/dedicated_server_ola_configure.py Show resolved Hide resolved
plugins/modules/dedicated_server_ola_configure.py Outdated Show resolved Hide resolved
plugins/modules/dedicated_server_ola_configure.py Outdated Show resolved Hide resolved
plugins/modules/dedicated_server_ola_unconfigure.py Show resolved Hide resolved
plugins/modules/dedicated_server_ola_wait.py Outdated Show resolved Hide resolved
plugins/modules/dedicated_server_ola_wait.py Outdated Show resolved Hide resolved
plugins/modules/dedicated_server_ola_wait.py Outdated Show resolved Hide resolved
@Fry-4TF1V Fry-4TF1V force-pushed the master branch 4 times, most recently from ab0fc96 to a1d0041 Compare January 7, 2025 21:50
@Fry-4TF1V
Copy link
Author

Hi @tortuegenialez,

I'm not an expert in Git, so tried to do my best to update files as requested. Hope it is good now.

tortuegenialez
tortuegenialez reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@tortuegenialez tortuegenialez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the modifications, I'm in doubt with the indentation of 2 lignes

plugins/modules/dedicated_server_ola_configure.py Outdated Show resolved Hide resolved
tortuegenialez
tortuegenialez approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@tortuegenialez tortuegenialez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tortuegenialez tortuegenialez tortuegenialez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fry-4TF1V @tortuegenialez