Skip to content

Commit

Permalink
Update ordering.rs
Browse files Browse the repository at this point in the history
  • Loading branch information
berkaysynnada committed Feb 23, 2025
1 parent 4bae63a commit f5e9789
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions datafusion/physical-expr/src/equivalence/ordering.rs
Original file line number Diff line number Diff line change
Expand Up @@ -237,16 +237,16 @@ impl OrderingEquivalenceClass {
None
}

/// Checks whether the given expression remains constant across all variations of [SortOptions].
/// Checks whether the given expression remains constant across all variations of [`SortOptions`].
///
/// This function determines if `expr` appears with every possible combination of `descending`
/// and `nulls_first` options. If `expr` meets this condition, it is effectively constant.
///
/// We primarily use [ConstExpr] to represent globally constant expressions. However, if an
/// We primarily use `ConstExpr` to represent globally constant expressions. However, if an
/// expression is only constant within secondary ordering constraints, this function helps
/// identify such cases.
///
/// TODO: If [SortOptions] eventually supports encoding constantness information, this function
/// TODO: If [`SortOptions`] eventually supports encoding constantness information, this function
/// may become obsolete.
pub fn is_expr_partial_const(&self, expr: &Arc<dyn PhysicalExpr>) -> bool {
let mut variants =
Expand Down

0 comments on commit f5e9789

Please sign in to comment.