Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the binance wallet #3505

Merged
merged 3 commits into from
Feb 6, 2025
Merged

adding the binance wallet #3505

merged 3 commits into from
Feb 6, 2025

Conversation

Defi-Moses
Copy link
Collaborator

@Defi-Moses Defi-Moses commented Feb 5, 2025

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

Summary by CodeRabbit

  • New Features
    • Introduced support for Binance Wallet, adding it as an option alongside existing choices.
    • Added a dedicated, visually distinctive icon for Binance Wallet.
    • Expanded wallet configuration to seamlessly integrate the new option, enhancing connectivity flexibility for users.
    • Updated wallet identifiers to include Binance Wallet in the application.

11f8c24: synapse-interface preview link
4456989: synapse-interface preview link
224d436: synapse-interface preview link

Copy link
Contributor

coderabbitai bot commented Feb 5, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes integrate support for Binance Wallet by extending the wallet options. A new entry is added to the WALLETS array with the corresponding icon, and a dedicated BinanceWalletIcon component is introduced. Additionally, the WalletId enum is updated with a new entry for Binance Wallet, and the wallet connectors configuration in the wallets setup file now includes the Binance wallet. The control flow for wallet interactions remains unchanged.

Changes

File(s) Change Summary
packages/synapse-interface/components/Wallet.tsx Added Binance Wallet option in the WALLETS array and imported BinanceWalletIcon.
packages/synapse-interface/components/icons/WalletIcons/BinanceWalletIcon.tsx Introduced a new BinanceWalletIcon component rendering an SVG icon for Binance Wallet.
packages/synapse-interface/utils/types/index.tsx Updated WalletId enum with BinanceWallet.
packages/synapse-interface/wagmiConfig.ts Integrated binanceWallet into wallet connectors configuration.
packages/synapse-interface/package.json Added dependency @binance/w3w-rainbow-connector-v2 with version ^1.0.2.

Suggested labels

M-synapse-interface, size/s, Typescript

Suggested reviewers

  • bigboydiamonds
  • aureliusbtc

Poem

I'm a bunny with hops so light,
Bringing Binance to our code's flight.
New wallet icon, crisp and fair,
With each line, I cheer and care.
Happy coding, let's bounce to delight! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Feb 5, 2025

Bundle Report

Changes will increase total bundle size by 324.34kB (1.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
synapse-interface-server-cjs 1.67MB 3.78kB (0.23%) ⬆️
synapse-interface-client-array-push 7.74MB 320.56kB (4.32%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: synapse-interface-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js 65.83kB 2.14MB 3.17%
static/chunks/4061.*.js -2.74kB 274.52kB -0.99%
static/chunks/6882.*.js (New) 258.47kB 258.47kB 100.0% 🚀
static/chunks/6221.*.js -2.74kB 126.08kB -2.13%
static/chunks/pages/index-*.js -1 bytes 65.46kB -0.0%
static/chunks/4097-*.js (New) 31.63kB 31.63kB 100.0% 🚀
static/chunks/pages/landing-*.js -1 bytes 30.75kB -0.0%
react-*.json 390 bytes 25.43kB 1.56%
server/middleware-*.js -4.39kB 16.93kB -20.6%
server/middleware-*.js 4.72kB 21.66kB 27.89% ⚠️
static/chunks/pages/swap-*.js -1 bytes 16.95kB -0.01%
static/chunks/pages/returntomonke-*.js -1 bytes 7.33kB -0.01%
static/IwBwgo866GCtVGe-BN3LL/_buildManifest.js (New) 6.72kB 6.72kB 100.0% 🚀
static/chunks/pages/lifi-*.js -1 bytes 6.63kB -0.02%
static/chunks/webpack-*.js 47 bytes 6.33kB 0.75%
static/chunks/pages/pools-*.js -1 bytes 5.9kB -0.02%
static/chunks/pages/pool/[poolId]-*.js -1 bytes 5.06kB -0.02%
static/chunks/pages/stake-*.js -1 bytes 2.54kB -0.04%
static/chunks/pages/stake/[routerIndex]-*.js -1 bytes 2.46kB -0.04%
static/chunks/995.*.js (New) 965 bytes 965 bytes 100.0% 🚀
static/IwBwgo866GCtVGe-BN3LL/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/chunks/7136-*.js (Deleted) -31.61kB 0 bytes -100.0% 🗑️
static/ggrGusEzsvRMjudb3IM2I/_buildManifest.js (Deleted) -6.72kB 0 bytes -100.0% 🗑️
static/ggrGusEzsvRMjudb3IM2I/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/pages/_app-*.js:

  • ./utils/types/index.tsx → Total Size: 4.83kB
view changes for bundle: synapse-interface-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
9645.js 46 bytes 385.83kB 0.01%
../pages/index.js 78 bytes 75.14kB 0.1%
7607.js 833 bytes 41.56kB 2.05%
../pages/landing.js 78 bytes 34.73kB 0.23%
../pages/swap.js 78 bytes 21.78kB 0.36%
../pages/landing/sections/SecuritySection.js 65 bytes 20.83kB 0.31%
../pages/landing/sections/UseCasesSection.js 65 bytes 16.7kB 0.39%
../pages/state-managed-bridge.js 65 bytes 13.23kB 0.49%
../pages/landing/sections/ExplorerSection.js 65 bytes 11.78kB 0.56%
../pages/stake/StakeCardTitle.js 65 bytes 11.23kB 0.58%
../pages/landing/sections/IntegrationSection.js 65 bytes 10.77kB 0.61%
../pages/landing/sections/ResourcesSection.js 65 bytes 10.48kB 0.62%
../pages/returntomonke.js 78 bytes 10.35kB 0.76%
../pages/pool/poolManagement.js 65 bytes 10.18kB 0.64%
../pages/_error.js 65 bytes 9.79kB 0.67%
../pages/pools.js 78 bytes 9.3kB 0.85%
../pages/pool/PoolInfoSection.js 65 bytes 9.06kB 0.72%
../pages/pool/[poolId].js 78 bytes 8.84kB 0.89%
../pages/pool/NoPoolBody.js 65 bytes 8.79kB 0.74%
../pages/lifi.js 65 bytes 8.69kB 0.75%
../pages/landing/sections/BridgeSection.js 65 bytes 8.68kB 0.75%
../pages/pool/components/LiquidityManagementTabs.js 65 bytes 8.57kB 0.76%
../pages/pool/poolManagement/WithdrawButton.js 65 bytes 8.3kB 0.79%
../pages/pool/poolManagement/Withdraw.js 65 bytes 8.08kB 0.81%
../pages/stake/StakeCard.js 65 bytes 7.96kB 0.82%
../pages/returntomonke/PfpGeneratorCard.js 65 bytes 7.85kB 0.84%
../pages/pool/PoolBody.js 65 bytes 7.69kB 0.85%
../pages/stake.js 78 bytes 7.62kB 1.03%
../pages/stake/[routerIndex].js 78 bytes 7.53kB 1.05%
../pages/landing/sections/HeroSection.js 65 bytes 7.15kB 0.92%
../pages/pool/PoolInfoSection/CurrencyReservesCard.js 65 bytes 7.03kB 0.93%
../pages/returntomonke/ImageUploader.js 65 bytes 6.82kB 0.96%
../pages/pool/PoolInfoSection/InfoSectionCard.js 65 bytes 5.74kB 1.15%
../pages/pool/components/ReceivedTokenSection.js 65 bytes 5.28kB 1.25%
../pages/pool/components/PriceImpactDisplay.js 65 bytes 5.25kB 1.25%
../pages/pool/poolManagement/DepositButton.js 65 bytes 4.9kB 1.34%
../pages/pool/poolManagement/Deposit.js 65 bytes 4.89kB 1.35%
../pages/pool/components/PoolTitle.js 65 bytes 4.8kB 1.37%
../pages/pool/PoolInfoSection/InfoSection.js 65 bytes 4.7kB 1.4%
../pages/pool/components/AugmentWithUnits.js 65 bytes 4.52kB 1.46%
../pages/pools/PoolCards.js 65 bytes 4.4kB 1.5%
../pages/landing/sections/HowItWorksSection.js 65 bytes 4.36kB 1.51%
../pages/bridge.js 65 bytes 4.33kB 1.52%
../pages/pools/PoolCard.js 65 bytes 3.9kB 1.7%
../pages/_app.js 65 bytes 2.54kB 2.62%

Files in 9645.js:

  • ./wagmiConfig.ts → Total Size: 1.17kB

  • ./utils/types/index.tsx → Total Size: 4.29kB

Files in 7607.js:

  • ./components/icons/WalletIcons/BinanceWalletIcon.tsx → Total Size: 1.17kB

  • ./components/Wallet.tsx → Total Size: 6.71kB

Copy link

cloudflare-workers-and-pages bot commented Feb 5, 2025

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 46718c2
Status: ✅  Deploy successful!
Preview URL: https://e9f9e54f.sanguine-fe.pages.dev
Branch Preview URL: https://feat-binance-wallet.sanguine-fe.pages.dev

View logs

@Defi-Moses Defi-Moses merged commit 88d46ec into master Feb 6, 2025
33 of 35 checks passed
@Defi-Moses Defi-Moses deleted the feat/binance-wallet branch February 6, 2025 00:32
@coderabbitai coderabbitai bot mentioned this pull request Feb 6, 2025
trajan0x added a commit that referenced this pull request Feb 6, 2025
trajan0x added a commit that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants