Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add height/width fields for future constants upgrade integration #3208

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Add height/width fields for future constants upgrade integration #3208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions packages/explorer-ui/components/misc/AssetImage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,13 @@ export const AssetImage = ({ tokenAddress, chainId, className }) => {
<div className="relative w-full">
<div className="flex justify-between ">
<div className="flex flex-row w-[90%] items-center">
<Image className={`${className}`} src={t?.icon} alt="" />
<Image
className={`${className}`}
src={t?.icon}
alt=""
height={16}
width={16}
/>
</div>
</div>
</div>
Expand All @@ -29,13 +35,21 @@ export const AssetImage = ({ tokenAddress, chainId, className }) => {
className={`inline mr-[.5rem] rounded-full ${className}`}
src={t?.icon}
alt=""
height={16}
width={16}
/>
</a>
)
} else {
return (
// temporary fix until either symbolToToken works better as a function or explorer indexer has the right token addresses
<Image className={`${className}`} src={USDC?.icon} alt="" />
<Image
className={`${className}`}
src={USDC?.icon}
alt=""
height={16}
width={16}
/>
// <QuestionMarkCircleIcon
// className={`inline w-5 h-5 mr-2 rounded-md ${className}`}
// strokeWidth={2}
Expand Down
2 changes: 2 additions & 0 deletions packages/explorer-ui/components/misc/ChainImage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ export const ChainImage = ({ chainId, imgSize = 'w-4 h-4', className }) => {
src={chain.chainImg}
className={`${imgSize} rounded-full mr-2 inline ${className}`}
alt={chain.name}
height={16}
width={16}
abtestingalpha marked this conversation as resolved.
Show resolved Hide resolved
/>
)
} else {
Expand Down
2 changes: 2 additions & 0 deletions packages/explorer-ui/components/misc/ChainInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ export const ChainInfo = ({
className={`inline rounded-full ${imgClassName}`}
src={chain?.chainImg}
alt={chain?.name}
height={16}
width={16}
/>
<p
className={`${textClassName} group-hover:text-[#8FEBFF] transition-colors duration-200`}
Expand Down
Loading