Skip to content

Commit

Permalink
[SymForce-External] Delete pylint
Browse files Browse the repository at this point in the history
Delete pylint

Move everything to ruff

Topic: rm-pylint
Closes #411
GitOrigin-RevId: de95bf10f605b03ad0f3962dd02e0ed952944efe
  • Loading branch information
aaron-skydio committed Dec 21, 2024
1 parent eaf147a commit af8b5fd
Show file tree
Hide file tree
Showing 137 changed files with 604 additions and 1,282 deletions.
12 changes: 5 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -53,21 +53,19 @@ check_types:
--exclude "symforce/examples/.*/gen/python2\.7/lcmtypes" \
--exclude third_party

# Run pylint on the symforce package, and tests
# TODO(aaron): Also run on other python code in symforce. Generated code will require a different
# config since it is py6 and contains a lot of duplicate code
pylint:
$(PYTHON) -m pylint symforce test/*.py
# Run ruff check
ruff_check:
ruff check

# Lint check for formatting and type hints
# This needs pass before any merge.
lint: check_types check_format pylint
lint: check_types check_format ruff_check

# Clean all artifacts
clean: docs_clean coverage_clean
rm -rf $(BUILD_DIR)

.PHONY: all reqs format check_format check_types pylint lint clean
.PHONY: all reqs format check_format check_types ruff_check lint clean

# -----------------------------------------------------------------------------
# Tests
Expand Down
25 changes: 2 additions & 23 deletions dev_requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ argh==0.31.2
# via
# skymarshal
# symforce (setup.py)
astroid==2.15.8
# via pylint
asttokens==2.4.1
# via stack-data
attrs==23.2.0
Expand Down Expand Up @@ -63,8 +61,6 @@ decorator==5.1.1
# via ipython
defusedxml==0.7.1
# via nbconvert
dill==0.3.8
# via pylint
docutils==0.20.1
# via
# breathe
Expand Down Expand Up @@ -103,8 +99,6 @@ ipython==8.12.3
# via ipykernel
ipython-genutils==0.2.0
# via symforce (setup.py)
isort==5.13.2
# via pylint
jedi==0.19.1
# via ipython
jinja2==3.1.4
Expand Down Expand Up @@ -134,8 +128,6 @@ jupyterlab-pygments==0.3.0
# via nbconvert
kiwisolver==1.4.5
# via matplotlib
lazy-object-proxy==1.10.0
# via astroid
llvmlite==0.41.1
# via numba
markdown-it-py==3.0.0
Expand All @@ -152,8 +144,6 @@ matplotlib-inline==0.1.7
# via
# ipykernel
# ipython
mccabe==0.7.0
# via pylint
mdit-py-plugins==0.4.1
# via myst-parser
mdurl==0.1.2
Expand Down Expand Up @@ -221,9 +211,7 @@ pip-tools==7.4.1
pkgutil-resolve-name==1.3.10
# via jsonschema
platformdirs==4.2.2
# via
# jupyter-core
# pylint
# via jupyter-core
plotly==5.22.0
# via symforce (setup.py)
ply==3.11
Expand All @@ -244,8 +232,6 @@ pygments==2.18.0
# ipython
# nbconvert
# sphinx
pylint==2.17.7
# via symforce (setup.py)
pyparsing==3.1.2
# via matplotlib
pyproject-hooks==1.1.0
Expand Down Expand Up @@ -277,7 +263,7 @@ rpds-py==0.18.1
# via
# jsonschema
# referencing
ruff==0.5.4
ruff==0.7.1
# via symforce (setup.py)
scipy==1.10.1
# via symforce (setup.py)
Expand Down Expand Up @@ -335,9 +321,6 @@ tomli==2.0.1
# build
# mypy
# pip-tools
# pylint
tomlkit==0.12.5
# via pylint
tornado==6.4
# via
# ipykernel
Expand All @@ -364,10 +347,8 @@ types-setuptools==69.5.0.20240513
# via symforce (setup.py)
typing-extensions==4.11.0
# via
# astroid
# ipython
# mypy
# pylint
tzdata==2024.1
# via pandas
urllib3==2.2.1
Expand All @@ -384,8 +365,6 @@ wheel==0.43.0
# via
# pip-tools
# symforce (setup.py)
wrapt==1.16.0
# via astroid
zipp==3.18.1
# via
# importlib-metadata
Expand Down
2 changes: 1 addition & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
# -- Project information -----------------------------------------------------

project = "symforce"
copyright = "2022, Skydio, Inc"
copyright = "2022, Skydio, Inc" # noqa: A001
author = "Skydio"

# The short X.Y version
Expand Down
4 changes: 2 additions & 2 deletions gen/python/sym/atan_camera_cal.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions gen/python/sym/double_sphere_camera_cal.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions gen/python/sym/equirectangular_camera_cal.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions gen/python/sym/linear_camera_cal.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/atan_camera_cal/camera_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/atan_camera_cal/group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/atan_camera_cal/lie_group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/double_sphere_camera_cal/camera_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/double_sphere_camera_cal/group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/double_sphere_camera_cal/lie_group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/equirectangular_camera_cal/camera_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/equirectangular_camera_cal/group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/linear_camera_cal/camera_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/linear_camera_cal/group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit af8b5fd

Please sign in to comment.