Skip to content

Commit

Permalink
Bump pybind
Browse files Browse the repository at this point in the history
Fixes #425

Our previous version of pybind didn't support py3.11.  pybind 2.13.6
supports all versions of python that we support.  There isn't much
downside to downloading an additional copy of pybind if you have an
older one installed that supports your version of python.  If we wanted
to we could write some table of minimum required versions based on
SYMFORCE_PYTHON's version

Topic: sf-pybind
  • Loading branch information
aaron-skydio committed Feb 24, 2025
1 parent d1ced09 commit 15a2ace
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions symforce/pybind/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@

include(FetchContent)

find_package(pybind11 2.9.2 QUIET)
find_package(pybind11 2.13.6 QUIET)
if (NOT pybind11_FOUND)
message(STATUS "pybind11 not found, adding with FetchContent")
# NOTE(brad): Set PYTHON_EXECUTABLE to ensure pybind11 uses the same
# python as the rest of symforce.
set(PYTHON_EXECUTABLE ${SYMFORCE_PYTHON})
FetchContent_Declare(
pybind11
URL https://github.com/pybind/pybind11/archive/v2.9.2.zip
URL_HASH SHA256=d1646e6f70d8a3acb2ddd85ce1ed543b5dd579c68b8fb8e9638282af20edead8
URL https://github.com/pybind/pybind11/archive/v2.13.6.zip
URL_HASH SHA256=d0a116e91f64a4a2d8fb7590c34242df92258a61ec644b79127951e821b47be6
)
FetchContent_MakeAvailable(pybind11)
else()
Expand Down

0 comments on commit 15a2ace

Please sign in to comment.