Fix next page buttons appearing on empty blog searches #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tumblr's internal API returns no data when no blog search results are found. This includes the necessary blog info to render the blog's header.
#173 worked around this by instead requesting the main page of a blog and then clearing the posts list as to simulate empty results. However, it neglected to clear the next attribute which contains the data required to fetch the next batch of content and is used by the frontend to determine whether to render a next page button.
This oversight caused the frontend to display a next page button incorrectly which will cause an error if a user attempts to navigate to the next page.