WIP: Configurable qos #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rjb0026 I don't have the ability to save the QoS parameters yet, and I haven't really tested this beyond getting it to compile. |
…figures itself to match the current configuration
rjb0026
reviewed
Aug 8, 2024
rjb0026
suggested changes
Aug 8, 2024
There was a problem hiding this comment.
Btw, I'm getting compiler warnings from plugins that include this file and others that have Q_OBJECT; after the class ... declaration because it is saying the ";" character is redundant. Can we go through and remove the ";" characters from the Q_OBJECT; lines?
Co-authored-by: Robert Brothers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the topic select UI to include QoS settings