Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow flag-based control of block falling direction via InvertFallingDirFlag field on FallingComponent #86

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

aonkeeper4
Copy link
Contributor

Also adds a property to Gravity Dream Blocks and Inversion Blocks to support this

@swoolcock
Copy link
Owner

Looks okay, but I'll probably go through and move some things around for optimisation, etc.

Also ahhhhhhhhhh all the whitespace reformatting!

When I go to clean up whitespace I'll probably do the entire project in one sweep.
@swoolcock
Copy link
Owner

@aonkeeper4 Can you please check that this still does what you want it to? The changes I made were:

  • Just use a single checking function rather than a wrapper property; I'd rather not have the set and get be out of sync if possible.
  • Cache the return of the check where possible (if it's guaranteed to be the same frame).
  • Reverted the Lua formatting; I'm going to do a full pass over the project at some point so it'll probably be its own branch.

@aonkeeper4
Copy link
Contributor Author

yeah this all seems to still be working as expected, thanks for taking a look!
also sorry about all the lua reformatting and me taking a while to respond, i don't really check github notifications

@swoolcock swoolcock merged commit 7c9275e into swoolcock:develop Aug 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants