fix: Use --package-path for test actions #971
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves "Unknown option '-C'" failures when running TestSwiftPackage actions
Matches how clean_swift_package is used in the build_swift_package function
clackary
requested review from
shahmishal and
justice-adams-apple
as code owners
|
I was able to run various TestSwiftPackage actions successfully with these changes. Partially resolves #926. It doesn't affect any production jobs to my knowledge, but it does allow me to run test actions locally. |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Updates the usage of
swift testto use--package-pathinstead of the deprecated-C.Resolves
Unknown option '-C'errors when attempting to run TestSwiftPackage actions.Also includes a minor refactor to prevent extraneous
swift package cleandebug output from printing. This was due to a difference inclean_swift_packagearguments.Acceptance Criteria
N/A -- no new project is being submitted for review