Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.1] Remove trailing comma in function call #8255

Open
wants to merge 1 commit into
base: release/6.1
Choose a base branch
from
Open

[6.1] Remove trailing comma in function call #8255

wants to merge 1 commit into from
+1 −1

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jan 29, 2025 •
edited
Loading

  • Explanation: This restores the ability to build SwiftPM using a Swift 6.0 compiler.
  • Scope: None
  • Issue: n/a
  • Original PR: n/a
  • Risk: Very low
  • Testing: Project builds
  • Reviewer: @dschaefer2 @jakepetroules

@ahoppen
Remove trailing comma in function call
d49d543 
This restores the ability to build SwiftPM using a Swift 6.0 compiler.
@ahoppen
Copy link
Member Author

ahoppen commented Jan 29, 2025

@swift-ci Please test

@dschaefer2
Copy link
Member

Really weird how that snuck in.

@dschaefer2 dschaefer2 enabled auto-merge (squash) January 29, 2025 00:55
@dschaefer2 dschaefer2 disabled auto-merge January 29, 2025 01:32
@dschaefer2
Copy link
Member

I have another change, #8256, that I pushed up before seeing this one that also fixes this, plus some other things for macro prebuilts. First one in wins :).

@bkhouri
Copy link
Contributor

bkhouri commented Jan 30, 2025

Really weird how that snuck in.

The CI pipelines all run against the nightly toolchain, and I believe 6.1 supports trailing commas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschaefer2 dschaefer2 dschaefer2 approved these changes

@jakepetroules jakepetroules jakepetroules approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

@francescomikulis francescomikulis Awaiting requested review from francescomikulis francescomikulis is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

@bkhouri bkhouri Awaiting requested review from bkhouri bkhouri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahoppen @dschaefer2 @bkhouri @jakepetroules