Merge pull request #5133 from jrflat/httpurlresponse-coding-test

Fix Dictionary ordering in TestHTTPURLResponse.test_NSCoding
swiftlang · Nov 6, 2024 · cb8377e · cb8377e
2 parents f812a85 + 13d628a
commit cb8377e
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/Tests/Foundation/TestHTTPURLResponse.swift b/Tests/Foundation/TestHTTPURLResponse.swift
@@ -236,7 +236,8 @@ class TestHTTPURLResponse: XCTestCase {
 
         //On macOS unarchived Archived then unarchived `URLResponse` is not equal.
         XCTAssertEqual(responseA.statusCode, responseB.statusCode, "Archived then unarchived http url response must be equal.")
-        XCTAssertEqual(Array(responseA.allHeaderFields.keys), Array(responseB.allHeaderFields.keys), "Archived then unarchived http url response must be equal.")
+        // Dictionary ordering is unpredictable after encoding/decoding because every Dictionary instance has its own hash table salt. Compare Sets of the keys instead.
+        XCTAssertEqual(Set(responseA.allHeaderFields.keys), Set(responseB.allHeaderFields.keys), "Archived then unarchived http url response must be equal.")
 
         for key in responseA.allHeaderFields.keys {
             XCTAssertEqual(responseA.allHeaderFields[key] as? String, responseB.allHeaderFields[key] as? String, "Archived then unarchived http url response must be equal.")