Fix issues related to item names being unnecessarily rendered (#56)

api/items.js

@@ -159,13 +159,13 @@ class Items {
     /*
     Use caching if it's safe to do so
 
-    The cache key must depend on the local this.#props.State revision
+    The cache key must depend on the local state revision
     in order to not get out of date, and that will only
     get updated if the this.#props.Client is listening for the
-    'this.#props.State.change' event
+    'state.change' event
     */
     if (
-      this.#props.Events.hasRemoteHandler('this.#props.State.change') &&
+      this.#props.Events.hasRemoteHandler('state.change') &&
       this.#props.State.getLocalRevision() !== 0
     ) {
       return this.#cache.cache(`${id}::${this.#props.State.getLocalRevision()}`, () => {

api/types.js

@@ -92,13 +92,13 @@ class Types {
     /*
     Use caching if it's safe to do so
 
-    The cache key must depend on the local this.#props.State revision
+    The cache key must depend on the local state revision
     in order to not get out of date, and that will only
     get updated if the client is listening for the
-    'this.#props.State.change' event
+    'state.change' event
     */
     if (
-      this.#props.Events.hasRemoteHandler('this.#props.State.change') &&
+      this.#props.Events.hasRemoteHandler('state.change') &&
       this.#props.State.getLocalRevision() !== 0
     ) {
       return this.#cache.cache(`${id}::${this.#props.State.getLocalRevision()}`, async () => this.getTypeUncached(id))

plugins/inspector/app/components/VariableStringInput/index.jsx

@@ -33,7 +33,19 @@ function getCompletion (str, completions) {
   return matches[0]
 }
 
+/**
+ * Get all possible paths to
+ * leaves from an object in
+ * dot-notation
+ * 
+ * @param { Object } obj 
+ * @returns { String[] }
+ */
 function getPathsFromObject (obj) {
+  if (!obj || typeof obj !== 'object') {
+    return []
+  }
+
   const out = []
   for (const key of Object.keys(obj)) {
     out.push(key)

plugins/rundown/app/components/RundownItem/index.jsx

@@ -81,8 +81,17 @@ export function RundownItem ({ index, item }) {
   const [typeProperties, setTypeProperties] = React.useState([])
 
   const [name] = useAsyncValue(() => {
+    /*
+    Make sure to check if there
+    really is a variable to render
+    as that operation is rather expensive
+    */
+    if (!bridge.variables.stringContainsVariable(item?.data?.name)) {
+      return item?.data?.name
+    }
+
     return bridge.items.renderValue(item.id, 'data.name')
-  }, [item])
+  }, [item?.data?.name])
 
   const displaySettings = shared?.plugins?.['bridge-plugin-rundown']?.settings?.display