Replace Kotlin lib with lib generated using openapi-codegen #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open source review
A serialization lib, will allow us to drop https://github.com/square/moshi |
svix-mman
force-pushed
the
mendy/new-kotlin-lib
branch
from
6c4d1da to
bd747da
Compare
Open source review
Allows me to easily test the API client |
svix-mman
force-pushed
the
mendy/new-kotlin-lib
branch
from
6ed68f7 to
8aef5c3
Compare
tasn
reviewed
Feb 13, 2025
tasn
reviewed
Feb 13, 2025
svix-james
previously approved these changes
Feb 13, 2025
svix-mman
force-pushed
the
mendy/new-kotlin-lib
branch
from
2dbc3c2 to
7b44749
Compare
The old models took up 45k loc
Also remove toString from string enums, This will be done elsewhere
TODO: Remove all debugging code
Changing the type of the `transformationsParams` from `Map<String, JsonElement>` to `Map<String, Any>` is already documented
svix-mman
force-pushed
the
mendy/new-kotlin-lib
branch
from
dc01f73 to
322d6d1
Compare
tasn
reviewed
Feb 13, 2025
tasn
reviewed
Feb 13, 2025
tasn
reviewed
Feb 13, 2025
tasn
reviewed
Feb 13, 2025
tasn
reviewed
Feb 13, 2025
Comment on lines
-99
to
+86
| @Deprecated(message = "This endpoint is deprecated.") | ||
| @Deprecated("") |
There was a problem hiding this comment.
Is it intentional that we are not using a deprecation message?
There was a problem hiding this comment.
Not yet supported by our codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
*PatchTest coverage
{Operation}{Method}Optionsserialization tests{ "file-generated-at": "2025-02-11T17:13:24.932994316+00:00", "git-rev": "f0ca7dbb583fc10b32b936ce80e40260b0628472", "openapi-codegen-version": "0.1.0", "openapi.json-sha256": "27c305c4c890291e9dd2506cebe18422317faea9963f3d9abf89a405731e3206" }ref: