Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to pnpm 8 #76

Merged
merged 6 commits into from
Nov 22, 2023
Merged

chore: upgrade to pnpm 8 #76

merged 6 commits into from
Nov 22, 2023

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Nov 21, 2023

Fix's Brittney's error from Discord

@dominikg
Copy link
Contributor

this is the monorepo package.json. @svitejs/svelte-preprocess-svg on npm does not have this engine limitation so it should be installable with any version of pnpm

@benmccann
Copy link
Contributor Author

Yeah. Brittney can confirm, but from the screenshot she shared, I think she was trying to contribute to this repo and was unable to because she had pnpm 8 installed. I tagged you on Discord where she was having trouble so you can see

@dominikg
Copy link
Contributor

as mentioned on discord, the whole monorepo needs to be updated to use pnpm@8 (packageManager field, update lockfile at least) the engine restriction exists so that contributors don't use a different pnpm major that could lead to lockfile changes or differences in dependencies in the workspace.

@benmccann
Copy link
Contributor Author

Ok. Bumped to pnpm 8

@dominikg
Copy link
Contributor

Ok. Bumped to pnpm 8

missing push?

@benmccann benmccann changed the title fix: allow package to be used with pnpm 8 chore: upgrade to pnpm 8 Nov 21, 2023
@benmccann
Copy link
Contributor Author

oops! fixed now!

@dominikg
Copy link
Contributor

arf, dropping node14 from CI is probably fine at this point, bumping deps (no major updates) hopefully fixes the audit, but could require a new release for svgo.

@benmccann
Copy link
Contributor Author

I fixed most of the audit warnings. The last two are unfixable by just upgrading packages because they're in unmaintained packages. I don't think that should block this PR since it's an issue on main unrelated to this which would block all PRs.

@dominikg dominikg merged commit 499b8e2 into svitejs:main Nov 22, 2023
6 checks passed
@dominikg
Copy link
Contributor

thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants