-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to pnpm 8 #76
Conversation
this is the monorepo package.json. |
Yeah. Brittney can confirm, but from the screenshot she shared, I think she was trying to contribute to this repo and was unable to because she had pnpm 8 installed. I tagged you on Discord where she was having trouble so you can see |
as mentioned on discord, the whole monorepo needs to be updated to use pnpm@8 (packageManager field, update lockfile at least) the engine restriction exists so that contributors don't use a different pnpm major that could lead to lockfile changes or differences in dependencies in the workspace. |
Ok. Bumped to pnpm 8 |
missing push? |
oops! fixed now! |
arf, dropping node14 from CI is probably fine at this point, bumping deps (no major updates) hopefully fixes the audit, but could require a new release for svgo. |
I fixed most of the audit warnings. The last two are unfixable by just upgrading packages because they're in unmaintained packages. I don't think that should block this PR since it's an issue on |
thank you!! |
Fix's Brittney's error from Discord