Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promote experimental.dynamicCompileOptions #765

Merged
merged 2 commits into from
Oct 15, 2023

Conversation

dominikg
Copy link
Member

@dominikg dominikg commented Oct 6, 2023

The option has been there for a while and is used. Promote it to proper with version 3.0.

Technically not a breaking change as we copy it over and log a warning.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with keeping the older promoted options for now 👍

@dominikg dominikg merged commit 3a45ae3 into main Oct 15, 2023
5 checks passed
@dominikg dominikg deleted the feat/promote-dynamic-compile-options branch October 15, 2023 18:52
@github-actions github-actions bot mentioned this pull request Oct 10, 2023
@github-actions github-actions bot mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants