Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update code-red, estree-walker, is-reference #6551

Merged
merged 3 commits into from
Jul 21, 2021

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Jul 21, 2021

update:

  • code-red@^0.2.2
  • estree-walker@^3.0.0
  • is-reference@^3.0.0

and dedupe the dependencies

Before submitting the PR, please make sure you do the following

  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@tanhauhau tanhauhau changed the title [chore] update [email protected] [chore] update code-red, estree-walker, is-reference Jul 21, 2021
@tanhauhau
Copy link
Member Author

tanhauhau commented Jul 21, 2021

lint failed, requires:

instead of adding "main" back to package.json,

probably we should disable the eslint rule instead:

sveltejs/eslint-config#15

@benmccann
Copy link
Member

lint is failing because is-reference and estree-walker don't have a main. We can either add a main to both and get Rich to cut a new release of both of them or disable the eslint rule
https://github.com/Rich-Harris/is-reference/blob/master/package.json
https://github.com/Rich-Harris/estree-walker/blob/master/package.json

@benmccann
Copy link
Member

jinx

@benmccann benmccann merged commit cb189ad into sveltejs:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants